Skip to content

Conversation

@BigSpaceships
Copy link
Contributor

Removed gulp from the build system for the frontend. I'd like to add back in the linting for frontend that happened but also that wasn't really working so it's not a regression either.

Also I'm sorry some of it is insane trying to update the build system with 8-9 year old dependencies in the project isn't fun (soon tm)

stevenmirabito
stevenmirabito previously approved these changes Nov 4, 2025
Copy link
Collaborator

@stevenmirabito stevenmirabito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, this looks great.

requirements.in Outdated
Flask-pyoidc~=3.14.3
Flask-SQLAlchemy~=3.1.1
gunicorn~=22.0.0
gunicorn~=20.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to downgrade gunicorn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was just when I removed the dependabot updates (no real reason)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigSpaceships does it work on gunicorn 22?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@import 'sweet-alert-animations';
@import './node_modules/bootstrap-sass/assets/stylesheets/bootstrap/mixins/forms';
@import 'ball-fall';
// @import 'ball-fall';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the effect of removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I couldn't figure out what this imported I'll look again before I'm done

@BigSpaceships BigSpaceships requested a review from a team November 9, 2025 18:06
gonna crash out over env variables stuff I'm so bad at updating the prod
one when I change local stuff
Copy link
Contributor

@costowell costowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attendance CSS seems to be a little broken
Image

@tallen42
Copy link
Contributor

Attendance CSS seems to be a little broken Image

Additionally, that is pulling non-active members, which it shouldn't be doing.

@tallen42
Copy link
Contributor

Additionally, that is pulling non-active members, which it shouldn't be doing.

Nevermind this is not a you problem, it's a problem from elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants